test: add test for cli #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
bjohansebas
force-pushed
the
add-test-cli
branch
from
ef410d0 to
b185778
Compare
bjohansebas
commented
Nov 28, 2024
bjohansebas
commented
Nov 28, 2024
bjohansebas
force-pushed
the
add-test-cli
branch
from
641fb3f to
d97d5f3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
kjugi
reviewed
Nov 28, 2024
kjugi
reviewed
Dec 6, 2024
Member
Author
|
Shouldn't we check if there were any files that changed? That's why I wanted it to return what the runner was giving back. |
Member
Author
|
It works fine when we don't compile, but when the code is being compiled, it throws an error. I'll look for a way to prevent that from happening. |
Member
Author
|
I think we can merge this now |
kjugi
reviewed
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are added for the CLI, making sure everything works properly with each action we perform in the CLI.