refactor: remove obsolete brotli and http2 support checks#221
Merged
bjohansebas merged 2 commits intoexpressjs:v2from Apr 7, 2025
Merged
refactor: remove obsolete brotli and http2 support checks#221bjohansebas merged 2 commits intoexpressjs:v2from
bjohansebas merged 2 commits intoexpressjs:v2from
Conversation
Phillip9587
commented
Feb 14, 2025
| brotli = hasBrotliSupport ? it.skip : it | ||
|
|
||
| brotli('should respond with gzip', function (done) { | ||
| it.skip('should respond with gzip', function (done) { |
Member
Author
There was a problem hiding this comment.
I set this test to it.skip because we may need it since there is an open issue for it: #220
bjohansebas
approved these changes
Apr 7, 2025
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the next major drops support for Node.js < v18 these checks are no longer needed.