increased code coverage of utils.js file#6386
Merged
bjohansebas merged 2 commits intoexpressjs:masterfrom Apr 11, 2025
Merged
Conversation
bjohansebas
approved these changes
Mar 18, 2025
UlisesGascon
approved these changes
Mar 18, 2025
wesleytodd
approved these changes
Mar 28, 2025
Member
wesleytodd
left a comment
wesleytodd
left a comment
There was a problem hiding this comment.
Hm, yeah looks like we have no coverage of that method? Always nice to see some increased test coverage but since we have none I will ask if you are willing to write a few more tests to do more than just this invalid case?
Not blocking, and we can merge this just fine but wanted to ask at least.
Contributor
Author
|
Definitely will take up this and try to cover the uncovered line of the files. but if possible we can proceed with merging this request, will make separate pull request for the remaining changes. |
Member
|
@ashish3011 thanks! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in file util.js in function acceptParams where if (splitIndex === -1) break; is not covered in test cases, so I suggest a test case to cover this.