test: added unit tests for utils.compileETag to cover valid and invalid inputs #6534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
UlisesGascon
left a comment
UlisesGascon
left a comment
There was a problem hiding this comment.
@sukdev24 thanks for helping the project! Can you run npm run lint -- --fix to solve the linting issues and commit the changes?
Contributor
Author
|
Thank for your response, will look at it.
And commit changes.
Best regards.
…On Tue, 27 May 2025, 10:36 Ulises Gascón, ***@***.***> wrote:
***@***.**** commented on this pull request.
@sukdev24 <https://github.com/sukdev24> thanks for helping the project!
Can you run npm run lint -- --fix to solve the linting issues and commit
the changes?
—
Reply to this email directly, view it on GitHub
<#6534 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BS4MFE3N5LSWBM7AADGEETD3AQPYHAVCNFSM6AAAAAB55NE642VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQNZQGE4TAOBVHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
bjohansebas
approved these changes
Jan 17, 2026
Member
bjohansebas
left a comment
bjohansebas
left a comment
There was a problem hiding this comment.
I’ve updated the tests so that instead of only checking whether it’s a function, they verify the behavior based on what it should return.
bjohansebas
changed the title
bjohansebas
added
tests
semver-ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contribution adds unit tests for the
utils.compileETag()function intest/utils.js.The tests verify behavior for:
true,false,"strong","weak"input valuesThese tests improve coverage and support new contributors reviewing ETag logic.