Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/response.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,11 @@ module.exports = res
res.status = function status(code) {
// Check if the status code is not an integer
if (!Number.isInteger(code)) {
throw new TypeError(`Invalid status code: ${JSON.stringify(code)}. Status code must be an integer.`);
throw new TypeError(`Invalid status code: ${String(code)} (${typeof code}). Status code must be an integer.`);
}
// Check if the status code is outside of Node's valid range
if (code < 100 || code > 999) {
throw new RangeError(`Invalid status code: ${JSON.stringify(code)}. Status code must be greater than 99 and less than 1000.`);
throw new RangeError(`Invalid status code: ${String(code)} (${typeof code}). Status code must be greater than 99 and less than 1000.`);
}

this.statusCode = code;
Expand Down
36 changes: 36 additions & 0 deletions test/res.sendStatus.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,41 @@ describe('res', function () {
.get('/')
.expect(500, /TypeError: Invalid status code/, done)
})

it('should raise error for BigInt status code', function (done) {
var app = express()

app.use(function (req, res) {
res.sendStatus(200n)
})

request(app)
.get('/')
.expect(500, /TypeError: Invalid status code: 200 \(bigint\)/, done)
})

it('should raise error for string status code', function (done) {
var app = express()

app.use(function (req, res) {
res.sendStatus('200')
})

request(app)
.get('/')
.expect(500, /TypeError: Invalid status code: 200 \(string\)/, done)
})

it('should raise error for object status code', function (done) {
var app = express()

app.use(function (req, res) {
res.sendStatus({ status: 200 })
})

request(app)
.get('/')
.expect(500, /TypeError: Invalid status code.*\(object\)/, done)
})
})
})
12 changes: 12 additions & 0 deletions test/res.status.js
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,18 @@ describe('res', function () {
.get('/')
.expect(500, /Invalid status code/, done);
});

it('should raise error for BigInt status code', function (done) {
var app = express();

app.use(function (req, res) {
res.status(200n).end();
});

request(app)
.get('/')
.expect(500, /TypeError: Invalid status code: 200 \(bigint\)/, done);
});
});
});
});
Expand Down