Skip to content

Conversation

@jonchurch
Copy link
Member

Problem

because we have required checks for CI, PRs that are markdown only will never trigger them, so will always appear blocked and waiting

an example is this doc only PR #6570:

image

Solution

make ci.yml run for all changes, even md

its not worth complicating the CI to solve for this by making each step aware of files changed and thus able to noop out of a real check. best to remove the "smart" addition I had made to ignore md only changes in CI in #5564

because we have required checks for CI, PRs that are markdown only will
never trigger them, so will always appear blocked and waiting

make ci.yml run for all changes, even md

its not worth complicating the CI to solve for this, so removing the
"smart" addition I had made to ignore md only changes in CI
Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR you’re referring to was created before #6632. It only needed a rebase and the CI would run again, so it wasn’t a blocker. Unless you also want the CI to run for Markdown files when there’s a push

@jonchurch
Copy link
Member Author

@bjohansebas thank you, I thought you had fixed this somewhere

No need for this then

@jonchurch jonchurch closed this Jan 6, 2026
@jonchurch jonchurch deleted the jonchurch/remove-paths-ignore branch January 6, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants