fix: prevent Content-Type header from being set to 'false'#7035
Open
veeceey wants to merge 1 commit intoexpressjs:masterfrom
Open
fix: prevent Content-Type header from being set to 'false'#7035veeceey wants to merge 1 commit intoexpressjs:masterfrom
veeceey wants to merge 1 commit intoexpressjs:masterfrom
Conversation
When res.set('Content-Type', value) is called with a value that
mime.contentType() cannot resolve, it returns false. This false
value was being passed directly to setHeader(), resulting in the
Content-Type header being set to the literal string "false".
Fall back to the original value when mime.contentType() returns
false, consistent with how res.type() already handles this case.
Fixes expressjs#7034
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7034
When
res.set('Content-Type', value)is called with a value thatmime.contentType()can't resolve (returnsfalse), the header ends up being set to the literal string"false".This happens because
mime.contentType()returnsfalsefor unrecognized types, and thatfalsegets passed straight tosetHeader(), which coerces it to a string.The fix is a one-liner — fall back to the original value when
mime.contentType()returnsfalse. This is consistent with howres.type()already handles the same case (it falls back to'application/octet-stream').Added a test to cover this edge case. Full test suite passes (1247 tests).