fix: fall back to JSON when JSONP callback sanitizes to empty string#7169
Closed
OussemaNehdi wants to merge 1 commit intoexpressjs:masterfrom
Closed
fix: fall back to JSON when JSONP callback sanitizes to empty string#7169OussemaNehdi wants to merge 1 commit intoexpressjs:masterfrom
OussemaNehdi wants to merge 1 commit intoexpressjs:masterfrom
Conversation
Move callback charset sanitization before the JSONP branch check so that callbacks containing only invalid characters (e.g. `?callback=!!!`) fall back to a plain JSON response instead of producing invalid JavaScript output with `text/javascript` Content-Type.
Contributor
|
Duplicate of #7161 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
res.jsonp()receives a callback containing only characters that getstripped by the sanitization regex (e.g.
?callback=!!!or?callback=<>@#),the current code sets
Content-Type: text/javascriptbefore sanitizing,then produces invalid JavaScript output: