-
Notifications
You must be signed in to change notification settings - Fork 1.8k
chore(fonts):⚡reduce font payload #1999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ShubhamOulkar
wants to merge
9
commits into
expressjs:gh-pages
Choose a base branch
from
ShubhamOulkar:performance-fonts
base: gh-pages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
994b59b
remove fontawesome webfonts
ShubhamOulkar bb33fae
⚡performance ⚡: add weight index open sans fonts
ShubhamOulkar 07bef61
Merge branch 'gh-pages' into performance-fonts
ShubhamOulkar ee1f667
ci: fix commenting
ShubhamOulkar 6c48d44
Merge branch 'performance-fonts' of https://github.com/ShubhamOulkar/…
ShubhamOulkar ab4f424
ci: skip lighthouse if only .md files are changed in PR
ShubhamOulkar 41f02cb
remove skiping .md files from lighthouse workflow
ShubhamOulkar 063ddc4
Merge branch 'gh-pages' into performance-fonts
ShubhamOulkar 181f784
add unicode range
ShubhamOulkar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
This file was deleted.
Oops, something went wrong.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,20 @@ | ||
@font-face { | ||
font-family: "Open Sans"; | ||
font-style: normal; | ||
font-weight: 100 700; | ||
font-weight: 300 800; | ||
font-display: swap; | ||
src: local("Open Sans"), | ||
url("./woff2/OpenSans.woff2") format("woff2"), | ||
url("./woff/OpenSans.woff") format("woff"), | ||
url("./woff2/open-sans-latin-wght-normal.woff2") format("woff2-variations"), | ||
url("./woff/OpenSans.woff") format("woff"); | ||
unicode-range: U+0000-00FF,U+0131,U+0152-0153,U+02BB-02BC,U+02C6,U+02DA,U+02DC,U+0304,U+0308,U+0329,U+2000-206F,U+20AC,U+2122,U+2191,U+2193,U+2212,U+2215,U+FEFF,U+FFFD; | ||
} | ||
|
||
@font-face { | ||
font-family: "Open Sans"; | ||
font-style: italic; | ||
font-weight: 100 700; | ||
font-weight: 300 800; | ||
font-display: swap; | ||
src: local("Open Sans"), | ||
url("./woff2/OpenSans-Italic.woff2") format("woff2"), | ||
url("./woff2/open-sans-latin-wght-italic.woff2") format("woff2-variations"), | ||
url("./woff/OpenSans-Italic.woff") format("woff"), | ||
} |
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not comfortable with this. pull_request_target has full permissions, and I don’t want to introduce vulnerabilities into this repository. I’m even thinking it might be better to handle the Lighthouse integration from Netlify.
Also, I feel that Lighthouse doesn’t provide very reliable data, in every PR I’ve seen it run, the results can be quite inaccurate, even when only a markdown file was changed.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our assets and website design logic causing this issue. I think we should get same result in netlify integration because netlify use
lighthouse
to generate results. refI support this and suggested before in my previous PR as well, we should consider netlify option just because we don't want unnecessary CI maintenance.
That why I prefer
pull_request
action for simple task like lighthouse. But this action can not comment on PR's. By the way, there should not be a problem with security because I am usingsha
. I have seen #2031 this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm removing this workflow from this PR. Let's just keep this PR for fonts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My latest commit got 100% results for desktop and on the edge for mobile. 😃