Skip to content

Commit d19770d

Browse files
committed
Use parseurl to parse the URL from request
1 parent 3eb9d33 commit d19770d

File tree

3 files changed

+4
-20
lines changed

3 files changed

+4
-20
lines changed

History.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
HEAD
22

33
* Resolve relative paths at middleware setup
4+
* Use parseurl to parse the URL from request
45

56
1.0.3 / 2014-03-20
67
==================

index.js

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
* Module dependencies.
1111
*/
1212

13+
var parseurl = require('parseurl');
1314
var resolve = require('path').resolve;
1415
var send = require('send');
1516
var url = require('url');
@@ -58,7 +59,7 @@ exports = module.exports = function(root, options){
5859
return function staticMiddleware(req, res, next) {
5960
if ('GET' != req.method && 'HEAD' != req.method) return next();
6061
var originalUrl = url.parse(req.originalUrl || req.url);
61-
var path = parse(req).pathname;
62+
var path = parseurl(req).pathname;
6263

6364
if (path == '/' && originalUrl.pathname[originalUrl.pathname.length - 1] != '/') {
6465
return directory();
@@ -114,22 +115,3 @@ function escape(html) {
114115
.replace(/>/g, '>')
115116
.replace(/"/g, '"');
116117
};
117-
118-
/**
119-
* Parse the `req` url.
120-
*
121-
* @param {ServerRequest} req
122-
* @return {Object}
123-
* @api private
124-
*/
125-
126-
function parse(req) {
127-
var parsed = url.parse(req.url);
128-
129-
if (parsed.auth && !parsed.protocol && ~parsed.href.indexOf('//')) {
130-
// This parses pathnames, and a strange pathname like //r@e should work
131-
parsed = url.parse(req.url.replace(/@/g, '%40'));
132-
}
133-
134-
return parsed;
135-
};

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
"url": "https://github.com/expressjs/serve-static/issues"
1313
},
1414
"dependencies": {
15+
"parseurl": "1.0.1",
1516
"send": "0.2.0"
1617
},
1718
"devDependencies": {

0 commit comments

Comments
 (0)