Skip to content

Proxy res.end(callback) calls correctly #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Proxy res.end(callback) calls correctly #751

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
431fbb7
Proxy res.end(callback) calls correctly
theneva May 18, 2020
2482cf2
work in progress, doesn't work properly
theneva May 20, 2020
fa4ba45
--wip-- [skip ci]
theneva May 22, 2020
7f70f94
it works
theneva May 22, 2020
2c8a4ed
clean up
theneva May 26, 2020
3832790
remove console.log statements
theneva May 26, 2020
e909d4a
remove more debug stuff
theneva May 26, 2020
655b36f
minimize diff
theneva May 26, 2020
afa311d
revert package.json changes
theneva May 26, 2020
b6bce2d
simplify node version test util
theneva May 26, 2020
76e3c10
test all cases & make it work when passing (data, callback)
theneva May 26, 2020
3591378
pull tests into describe block
theneva May 26, 2020
0a5d51a
extract node version support stuff to variable
theneva May 26, 2020
f93f995
switch from call to apply
theneva May 26, 2020
6e88688
mutate arguments to Make It Work
theneva May 26, 2020
647edce
update
theneva May 27, 2020
94a85cd
what
theneva May 27, 2020
c9abb7e
wat
theneva May 27, 2020
5fce3e3
still WIP
theneva May 27, 2020
d4856f8
clean up
theneva May 28, 2020
a5b85af
don't use .only
theneva May 28, 2020
3a5df79
don't overwrite second argument if it isn't encoding
theneva May 28, 2020
a578c50
don't assert or call done if not required
theneva May 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ function session(options) {
return ret;
}

if (chunk == null) {
if (chunk == null || typeof chunk === 'function') {
ret = true;
return ret;
}
Expand Down
17 changes: 17 additions & 0 deletions test/session.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,23 @@ describe('session()', function(){
.expect(200, 'Hello, world!', done);
})

it('should handle res.end(callback) calls', function (done) {
var callbackHasBeenCalled = false;

var server = createServer(null, function (req, res) {
function callback() {
callbackHasBeenCalled = true;
}

res.end(callback);
});

request(server).get('/').expect(200, '', function () {
assert.ok(callbackHasBeenCalled);
done();
})
});

it('should handle res.end(null) calls', function (done) {
var server = createServer(null, function (req, res) {
res.end(null)
Expand Down