fix: Remove unnecessary makevars.ucrt#414
Merged
JosiahParry merged 3 commits intoextendr:mainfrom Feb 20, 2025
albersonmiranda:makevars.ucrt
Merged
fix: Remove unnecessary makevars.ucrt#414JosiahParry merged 3 commits intoextendr:mainfrom albersonmiranda:makevars.ucrt
JosiahParry merged 3 commits intoextendr:mainfrom
albersonmiranda:makevars.ucrt
Conversation
Contributor
|
Thank you @albersonmiranda ! The changes to libR-sys actually require that the minimum supported version of R is 4.2. I think we should set the minimum supported version of R to 4.2. see #375 |
Contributor
|
@albersonmiranda can you add a note to the changelog? I think we can skip the lintr failure right now and add exclusions for the standalone files using the .lintr file https://lintr.r-lib.org/articles/lintr.html at a later point |
JosiahParry
approved these changes
Feb 20, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
makevars.ucrttemplates and updates tests and snaps. Closes #332 .