Skip to content

fix: Remove unnecessary makevars.ucrt#414

Merged
JosiahParry merged 3 commits intoextendr:mainfrom
albersonmiranda:makevars.ucrt
Feb 20, 2025
Merged

fix: Remove unnecessary makevars.ucrt#414
JosiahParry merged 3 commits intoextendr:mainfrom
albersonmiranda:makevars.ucrt

Conversation

@albersonmiranda
Copy link
Contributor

Removes makevars.ucrt templates and updates tests and snaps. Closes #332 .

@JosiahParry
Copy link
Contributor

Thank you @albersonmiranda ! The changes to libR-sys actually require that the minimum supported version of R is 4.2.

I think we should set the minimum supported version of R to 4.2. see #375

@JosiahParry
Copy link
Contributor

@albersonmiranda can you add a note to the changelog? I think we can skip the lintr failure right now and add exclusions for the standalone files using the .lintr file https://lintr.r-lib.org/articles/lintr.html at a later point

@JosiahParry JosiahParry enabled auto-merge (squash) February 20, 2025 20:32
@JosiahParry JosiahParry merged commit 277c82e into extendr:main Feb 20, 2025
19 checks passed
@codecov
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.88%. Comparing base (cbd93f6) to head (3f5efc6).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
R/source.R 76.41% <100.00%> (ø)
R/use_extendr.R 98.94% <ø> (-0.04%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Makevars.ucrt is no longer needed

2 participants