Skip to content

Conversation

@JosiahParry
Copy link
Contributor

Closes #482

This changes the regex to exclude #[extendr(default = "...")] from the extract_meta() function allowing the knitr engine to continue working.

@JosiahParry
Copy link
Contributor Author

related extendr/extendr#952

@JosiahParry JosiahParry requested a review from CGMossa October 25, 2025 17:24
Copy link
Member

@CGMossa CGMossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JosiahParry JosiahParry enabled auto-merge (squash) October 25, 2025 17:34
@JosiahParry JosiahParry merged commit 841b343 into main Oct 25, 2025
19 checks passed
@JosiahParry JosiahParry deleted the fix/extendr-default branch October 25, 2025 17:35
@codecov
Copy link

codecov bot commented Oct 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.34%. Comparing base (f9f0c8e) to head (c7f90c9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
R/find_exports.R 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(knitr): extendrsrc doesn't support new #[extendr(default="")] syntax

2 participants