fix: Messing static flags in php_impl proc macro#419
Merged
Xenira merged 1 commit intoextphprs:masterfrom Apr 7, 2025
Merged
Conversation
Member
|
Nice catch. Would you mind including an integration test as well. Will have a closer look at the implementation this evening. |
a12c512 to
c4a8270
Compare
Xenira
requested changes
Apr 6, 2025
c4a8270 to
fa00137
Compare
Xenira
approved these changes
Apr 7, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If try class static method from php it throws exception
Cause in proc_macros missing usage of MethodFlags::Static
In PR i change FnBuilder from single additional modifier with flag abstract to Vec, Myabe we should make uniq Vec, idk)