Skip to content

fix(macro): return error when old macro attributes are used #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2025
Merged

fix(macro): return error when old macro attributes are used #465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions crates/macros/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,11 @@ extern crate proc_macro;
/// # fn main() {}
/// ````
#[proc_macro_attribute]
pub fn php_class(_args: TokenStream, input: TokenStream) -> TokenStream {
pub fn php_class(args: TokenStream, input: TokenStream) -> TokenStream {
let input = parse_macro_input!(input as ItemStruct);
if !args.is_empty() {
return err!(input => "`#[php_class(<args>)]` args are no longer supported. Please use `#[php(<args>)]` instead.").to_compile_error().into();
}

class::parser(input)
.unwrap_or_else(|e| e.to_compile_error())
Expand Down Expand Up @@ -363,8 +366,11 @@ pub fn php_class(_args: TokenStream, input: TokenStream) -> TokenStream {
/// translated into an exception and thrown. See the section on
/// [exceptions](../exceptions.md) for more details.
#[proc_macro_attribute]
pub fn php_function(_args: TokenStream, input: TokenStream) -> TokenStream {
pub fn php_function(args: TokenStream, input: TokenStream) -> TokenStream {
let input = parse_macro_input!(input as ItemFn);
if !args.is_empty() {
return err!(input => "`#[php_function(<args>)]` args are no longer supported. Please use `#[php(<args>)]` instead.").to_compile_error().into();
}

function::parser(input)
.unwrap_or_else(|e| e.to_compile_error())
Expand Down Expand Up @@ -423,8 +429,11 @@ pub fn php_function(_args: TokenStream, input: TokenStream) -> TokenStream {
/// var_dump(MANUAL_CONSTANT); // string(12) "Hello world!"
/// ```
#[proc_macro_attribute]
pub fn php_const(_args: TokenStream, input: TokenStream) -> TokenStream {
pub fn php_const(args: TokenStream, input: TokenStream) -> TokenStream {
let input = parse_macro_input!(input as ItemConst);
if !args.is_empty() {
return err!(input => "`#[php_const(<args>)]` args are no longer supported. Please use `#[php(<args>)]` instead.").to_compile_error().into();
}

constant::parser(input)
.unwrap_or_else(|e| e.to_compile_error())
Expand Down Expand Up @@ -498,8 +507,11 @@ pub fn php_const(_args: TokenStream, input: TokenStream) -> TokenStream {
/// # fn main() {}
/// ```
#[proc_macro_attribute]
pub fn php_module(_args: TokenStream, input: TokenStream) -> TokenStream {
pub fn php_module(args: TokenStream, input: TokenStream) -> TokenStream {
let input = parse_macro_input!(input as ItemFn);
if !args.is_empty() {
return err!(input => "`#[php_module(<args>)]` args are no longer supported. Please use `#[php(<args>)]` instead.").to_compile_error().into();
}

module::parser(input)
.unwrap_or_else(|e| e.to_compile_error())
Expand Down Expand Up @@ -685,8 +697,11 @@ pub fn php_module(_args: TokenStream, input: TokenStream) -> TokenStream {
///
/// [`php_async_impl`]: ./async_impl.md
#[proc_macro_attribute]
pub fn php_impl(_args: TokenStream, input: TokenStream) -> TokenStream {
pub fn php_impl(args: TokenStream, input: TokenStream) -> TokenStream {
let input = parse_macro_input!(input as ItemImpl);
if !args.is_empty() {
return err!(input => "`#[php_impl(<args>)]` args are no longer supported. Please use `#[php(<args>)]` instead.").to_compile_error().into();
}

impl_::parser(input)
.unwrap_or_else(|e| e.to_compile_error())
Expand Down
Loading