chore(bindings): update docsrs_bindings.rs to PHP 8.4
#478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 16035418864Details
💛 - Coveralls |
Xenira
force-pushed
the
447-update-docsrs-bindings-to-php-84
branch
from
9f14ddc to
5a02863
Compare
Member
|
Nice one and maybe upgrading bindgen? |
Member
Author
|
Bindgen is making trouble upgrading. Will investigate after next release. EDIT2: Nvm, I am stupid. This always trips me up https://github.com/davidcole1340/ext-php-rs/blob/5a02863c3b672e44353ba9aca6f22776a9386b93/src/zend/globals.rs#L205-L211 conditions are the wrong way around if I see it correctly. Verifying right now. EDIT: Not the wrong way around, just not the right condition |
Xenira
force-pushed
the
447-update-docsrs-bindings-to-php-84
branch
from
5a02863 to
736c4e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #447