Skip to content

docs: Add missing parenthesis #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 5, 2025
+2 −2
Merged

docs: Add missing parenthesis #486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2020814
docs: Add missing parenthesis
Stranger6667 Jul 5, 2025
0469e10
docs: Update lib docs
Stranger6667 Jul 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/macros/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,7 @@ pub fn php_module(args: TokenStream, input: TokenStream) -> TokenStream {
///
/// The rest of the options are passed as separate attributes:
///
/// - `#[php(defaults(i = 5, b = "hello")]` - Sets the default value for
/// - `#[php(defaults(i = 5, b = "hello"))]` - Sets the default value for
/// parameter(s).
/// - `#[php(optional = i)]` - Sets the first optional parameter. Note that this
/// also sets the remaining parameters as optional, so all optional parameters
Expand Down
2 changes: 1 addition & 1 deletion guide/src/macros/impl.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ be named `self_`. This can also be used to return a reference to `$this`.

The rest of the options are passed as separate attributes:

- `#[php(defaults(i = 5, b = "hello")]` - Sets the default value for parameter(s).
- `#[php(defaults(i = 5, b = "hello"))]` - Sets the default value for parameter(s).
- `#[php(optional = i)]` - Sets the first optional parameter. Note that this also sets
the remaining parameters as optional, so all optional parameters must be a
variant of `Option<T>`.
Expand Down
Loading