fix: replace bare U+26A0 warning sign with emoji-presentation ⚠️#1660
fix: replace bare U+26A0 warning sign with emoji-presentation ⚠️#1660withsivram wants to merge 1 commit intoeyaltoledano:mainfrom
Conversation
eyaltoledano#1394) Text-presentation ⚠ (U+26A0) is treated as a narrow/1-column character by terminal width calculators (including boxen's), causing box borders to misalign when it appears in titles or content. Adding the U+FE0F variant selector forces emoji presentation, which renderers correctly measure as 2 columns, keeping boxen borders properly aligned. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughUpdates warning symbol prefixes across six CLI files from text presentation ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates CLI warning glyphs to enforce emoji presentation (⚠️) so terminal width calculators (e.g., boxen/string-width) consistently treat the character as double-width and avoid centered-title/border misalignment.
Changes:
- Replaced remaining text-presentation warning signs (
⚠) with emoji-presentation (⚠️) in warning boxes and warning log output. - Updated deprecation warnings and watch-mode error output to use
⚠️for consistent rendering across terminals.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/modules/prompt-manager.js | Uses ⚠️ in schema-validation-disabled warning log message. |
| scripts/modules/error-formatter.js | Uses ⚠️ in displayWarning() box title/content to prevent boxen width miscalc. |
| scripts/modules/task-manager/tag-management.js | Uses ⚠️ in tag deletion warning/notification strings shown in boxen output. |
| scripts/modules/commands.js | Uses ⚠️ in deprecated tag-command warnings printed to console. |
| scripts/modules/task-manager/migrate.js | Uses ⚠️ in migration logger’s warn indicator. |
| apps/cli/src/commands/list.command.ts | Uses ⚠️ in watch-mode error output line. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
⚠(U+26A0, text presentation) with⚠️(U+26A0 + U+FE0F, emoji presentation) across 6 files⚠is measured as 1 column by terminal width calculators (including boxen), causing box borders to misalign when it appears in titles or contentFiles changed
scripts/modules/prompt-manager.js— 1 instancescripts/modules/error-formatter.js— 1 instancescripts/modules/task-manager/tag-management.js— 2 instancesscripts/modules/commands.js— 5 instances (deprecation warnings)scripts/modules/task-manager/migrate.js— 1 instanceapps/cli/src/commands/list.command.ts— 1 instanceTest plan
Fixes #1394
🤖 Generated with Claude Code
Summary by CodeRabbit