Images draft

[theottm]

Hi!

I hacked a bit on a solution to integrate images from org into anki notes and vice-versa. It still has a few rough edges and I didn't try it out much yet. But it reached a point where at least for me it seems to work fine. I wanted to share it so other can try it out and comment the code and usage.

The general idea is the following. Media are stored in a special folder under the Anki dir. To sync with AnkiWeb the media need to be there, it seems not possible to use links. So for the direction org->anki we need to copy the images to the media dir of anki. Also we need to strip of the local path before the image name in the org links. For the anki->org direction we can just directly point to the media dir of anki. This is used when importing a deck that already had images.

Concretely I added the following:

• a custom variable org-anki-media-dir which points to where anki stores media.
• anki->org: in org-anki--html-to-org I wrapped the output string to add org-anki-media-dir as a prefix to all links. This relies on org-ml for now, not sure if you want to add this dependency.
• org->anki: in org-anki--string-to-html I wrapped the string to remove the folder from all links. Also relies on org-ml
• org-anki: I added a function org-anki-copy-images which copies all the images from links under the subtree at point (this could be changed) to anki media dir. This also relies on org-ml.

What do you think about adding org-ml as a new dependency? I feel more comfortable using this than direct string insertion.

WDYT?

[eyeinsky]

Thanks! I'm short on time this week, but will definitely look into this!

[ceed0]

It would be better to use link abbreviations to make it much less painful to change paths.

Also, org-anki-copy-images will filter out any non-file: links, including attachment:. Talking about it, maybe something like simple integration with org-attach will do the trick? You just use DIR property and point it to the media storage and org-attach does the rest.

[eyeinsky]

I looked at the code and have following feedback:

• make default media path nil and skip adding/removing links when it's nil, as media path is different for different OS's (e.g mine is ~/.local/share/Anki2/Markus/collection.media)
  • don't run the add/remove-links-code-path at all when media path is nil
• having org-ml as dependency looks good (as it aims to provide a nicer API for org-mode then it can very well become useful in other places too!)
• when converting to html, will the links in org-mode ([[..]]) become html images? (I.e <img src='..' and not links like <a href='..'>)
  • perhaps the mentioned link abbreviations? For example [[anki-img:path/to/img.jpg]] would be turned to <img> tags, other links would be kept as <a> elements. (Not saying it should be like this, simply thinking out loud)

Linking related issue #17

[theottm]

Thanks for your feedback both of you. I will have more time in a few weeks to look into this.

[theottm]

No problem, its still very much work in progress.

…

On Fri, Jun 10, 2022, 10:36 Markus Läll ***@***.***> wrote: Thanks! I'm short on time this week, but will definitely look into this! — Reply to this email directly, view it on GitHub <#43 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHKQJUIV24SDETSV656QEMDVOL5CLANCNFSM5YA2KBFQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[threddast]

Is this still being worked on? would be really neat to have image support

[LuciusChen]

This PR is valid, but the org-anki-media-path in "Files Changed" should be changed to org-anki-media-dir. At first, I didn't know that org-anki-copy-images needed to be called separately, and I pondered over it for a long time 😂. I used advice-add to override it, which is very convenient. Thank you.

[LuciusChen]

There is a slight issue with the org-ml-match-map in org-ml. When the text starts with bold formatting, the *text* will be recognized as an org heading and ignored. As a result, any text starting with * cannot be synchronized to Anki.

[1over137]

Is this still being worked on? It would be nice to have proper image export support. This also seems to not handle images from attach: links. attach: links use a short file name, but the full file path can be obtained by using org-export-expand

[theottm]

I won't be working for this in the future unfortunately. I kind of have my own fork of org-anki that is now too far apart from this code base. I'll consider publishing it at some point if I find time to clean it up.

[eyeinsky]

@theottm Do you mind if I continue work based on your commits? I might have time for this during Christmas holidays.

[1over137]

I personally think a cleaner approach is to send the images using AnkiConnect by populating the "picture" field of the json, but maybe that would not allow images to be placed anywhere within the field, only the end, so if you have multiple images it may not have the intended result (but I don't think I ever made an anki note with multiple pictures). All we need to do is to strip out the attach: or file: link, get the actual file, and send the path to file.

This would not automatically allow importing decks, though.

[theottm]

@eyeinsky no, please go ahead, i'd be glad!