Draft
Conversation
Contributor
Author
|
oh wow, it looks like public_in_private's been merged on stable! |
RFC #3516 has been merged and the public in private changes are on stable. It's tripping clippy on stable, so let's fully remove it from our codebase.
This change attempts to put unstable features behind an opt-in feature flag as requested by issue eyre-rs#120. Unstable lints and compile_test.rs are both gated by this feature which is added unconditionally to all CI that touches more than just stable. As expressed in issue eyre-rs#120, I have some concerns about *needing* to gate compile_test.rs behind feature = "unstable". I'm not certain that this unstable-less nightly eyre will work in production due to the reason that compile_test.rs fails: three of our dependencies, anyhow, thiserror, and proc-macro, all use a test for a nightly toolchain to gate unstable features. Maybe I'm wrong though and this change is sufficient!
Contributor
Author
|
I rebased to my other PR to get rid of the clippy fail, we can remove that before pushing if we want to send this first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change attempts to put unstable features behind an opt-in feature flag as requested by issue #120. Unstable lints and compile_test.rs are both gated by this feature which is added unconditionally to all CI that touches more than just stable.
As expressed in issue #120, I have some concerns about needing to gate compile_test.rs behind feature = "unstable". I'm not certain that this unstable-less nightly eyre will work in production due to the reason that compile_test.rs fails: three of our dependencies, anyhow, thiserror, and proc-macro, all use a test for a nightly toolchain to gate unstable features. Maybe I'm wrong though and this change is sufficient!