Option to disable tab and chat formatting#78
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds configuration options to disable chat and tab formatting in LuckPrefix. The feature allows users to selectively enable or disable the formatting features through new config options Chat-Formatting and Tab-Formatting.
- Adds two new boolean configuration options with default values set to
true - Implements early return checks in chat listeners and tab update methods
- Updates documentation to use PaperMC's MiniMessage format reference
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| luckprefix-common/src/main/java/de/eztxm/luckprefix/common/config/MainConfig.java | Adds config defaults, getter methods, and comments for the new formatting toggle options; also changes Long to long primitive for getUpdateTime() |
| luckprefix-common/src/main/java/de/eztxm/luckprefix/common/config/GroupsConfig.java | Updates documentation comments to reference PaperMC's MiniMessage format URL |
| luckprefix-modern/src/main/java/de/eztxm/luckprefix/listener/ChatListener.java | Adds early return when chat formatting is disabled; reorganizes config service initialization to top of method |
| luckprefix-modern/src/main/java/de/eztxm/luckprefix/LuckPrefix.java | Adds early return in updateGroups() when tab formatting is disabled |
| luckprefix-modern-spigot/src/main/java/de/eztxm/luckprefix/listener/ChatListener.java | Same changes as modern variant for chat formatting toggle |
| luckprefix-modern-spigot/src/main/java/de/eztxm/luckprefix/LuckPrefix.java | Adds tab formatting check and refactors to reuse config variable |
| luckprefix-modern-paper/src/main/java/de/eztxm/luckprefix/listener/ChatListener.java | Same changes as modern variant for chat formatting toggle |
| luckprefix-modern-paper/src/main/java/de/eztxm/luckprefix/LuckPrefix.java | Adds early return in updateGroups() when tab formatting is disabled |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
luckprefix-common/src/main/java/de/eztxm/luckprefix/common/config/MainConfig.java
Outdated
Show resolved
Hide resolved
luckprefix-common/src/main/java/de/eztxm/luckprefix/common/config/MainConfig.java
Outdated
Show resolved
Hide resolved
luckprefix-modern/src/main/java/de/eztxm/luckprefix/LuckPrefix.java
Outdated
Show resolved
Hide resolved
luckprefix-modern-paper/src/main/java/de/eztxm/luckprefix/LuckPrefix.java
Outdated
Show resolved
Hide resolved
luckprefix-common/src/main/java/de/eztxm/luckprefix/common/config/MainConfig.java
Outdated
Show resolved
Hide resolved
…fig/MainConfig.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…fig/MainConfig.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
….java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…Prefix.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…fig/MainConfig.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.