show containers in server tables for bare servers#51
Open
tecknicaltom wants to merge 1 commit intoezra-buckingham:mainfrom
Open
show containers in server tables for bare servers#51tecknicaltom wants to merge 1 commit intoezra-buckingham:mainfrom
tecknicaltom wants to merge 1 commit intoezra-buckingham:mainfrom
Conversation
When printing out the server table (e.g. with the show command), for bare servers with containers, print out the containers to help differentiate servers. Before: ``` │ curbless-unodious │ bare │ ... ``` After: ``` │ curbless-unodious │ bare (gophish) │ ... ```
ezra-buckingham
requested changes
Apr 20, 2023
Owner
ezra-buckingham
left a comment
There was a problem hiding this comment.
I love this idea, I just had not intended for bareservers to be the only ones with containers installed on them. I would remove the logic checking server type.
Contributor
Author
|
if that's the case, would it make more sense to have the containers listed with server_type as this diff does, or pull it out into its own column? |
Collaborator
|
If the server type if is a redirector, the service should be listed as well: http, https, dns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When printing out the server table (e.g. with the show command), for bare servers with containers, print out the containers to help differentiate servers.
Before:
After: