Skip to content

show containers in server tables for bare servers#51

Open
tecknicaltom wants to merge 1 commit intoezra-buckingham:mainfrom
tecknicaltom:show_containers
Open

show containers in server tables for bare servers#51
tecknicaltom wants to merge 1 commit intoezra-buckingham:mainfrom
tecknicaltom:show_containers

Conversation

@tecknicaltom
Copy link
Contributor

When printing out the server table (e.g. with the show command), for bare servers with containers, print out the containers to help differentiate servers.

Before:

╒═══════════════════╤═══════════════╤
│ server_name       │ server_type   │
╞═══════════════════╪═══════════════╪
│ curbless-unodious │ bare          │ ...

After:

╒═══════════════════╤════════════════╤
│ server_name       │ server_type    │
╞═══════════════════╪════════════════╪
│ curbless-unodious │ bare (gophish) │ ...

When printing out the server table (e.g. with the show command), for
bare servers with containers, print out the containers to help
differentiate servers.

Before:
```
│ curbless-unodious │ bare          │ ...
```

After:
```
│ curbless-unodious │ bare (gophish) │ ...
```
Copy link
Owner

@ezra-buckingham ezra-buckingham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this idea, I just had not intended for bareservers to be the only ones with containers installed on them. I would remove the logic checking server type.

@tecknicaltom
Copy link
Contributor Author

if that's the case, would it make more sense to have the containers listed with server_type as this diff does, or pull it out into its own column?

@leebaird
Copy link
Collaborator

If the server type if is a redirector, the service should be listed as well: http, https, dns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants