-
Notifications
You must be signed in to change notification settings - Fork 24
[WIP] Convert X-Location-Id into tags for non-view responses #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| <?php | ||
| /** | ||
| * @copyright Copyright (C) eZ Systems AS. All rights reserved. | ||
| * @license For full copyright and license information view LICENSE file distributed with this source code. | ||
| */ | ||
|
|
||
| namespace EzSystems\PlatformHttpCacheBundle\ResponseTagger\Delegator; | ||
|
|
||
| use EzSystems\PlatformHttpCacheBundle\ResponseConfigurator\ResponseCacheConfigurator; | ||
| use EzSystems\PlatformHttpCacheBundle\ResponseTagger\ResponseTagger; | ||
| use Symfony\Component\HttpFoundation\Response; | ||
| use eZ\Publish\API\Repository\Repository; | ||
|
|
||
| /** | ||
| * This class conver the deprecated X-Location-Id in path-$locationId | ||
| * It handles all the non-view responses when X-Location-Id is present. | ||
| */ | ||
| class XLocationIdBCTagger implements ResponseTagger | ||
| { | ||
| /** | ||
| * @var Repository | ||
| */ | ||
| private $repository; | ||
|
|
||
| /** | ||
| * @var ResponseTagger | ||
| */ | ||
| private $locationTagger; | ||
|
|
||
| const LOCATION_ID_HEADER = 'X-Location-Id'; | ||
|
|
||
| public function __construct( | ||
| Repository $repository, | ||
| ResponseTagger $locationTagger | ||
| ) { | ||
| $this->repository = $repository; | ||
| $this->locationTagger = $locationTagger; | ||
| } | ||
|
|
||
| public function tag(ResponseCacheConfigurator $configurator, Response $response, $view) | ||
| { | ||
| if ($view !== null || !$response->headers->has(static::LOCATION_ID_HEADER)) { | ||
| return null; | ||
| } | ||
|
|
||
| $locationIds = explode("|", $response->headers->get(static::LOCATION_ID_HEADER)); | ||
| foreach ($locationIds as $locationId) { | ||
| try { | ||
| $location = $this->repository->getLocationService()->loadLocation($locationId); | ||
| $this->locationTagger->tag($configurator, $response, $location); | ||
| $response->headers->remove(static::LOCATION_ID_HEADER); | ||
| } catch (\Exception $e) { | ||
| // do nothing | ||
| } | ||
| } | ||
|
|
||
| return $this; | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't see why this needs to be added, afaik REST already sets
s-maxagedoesn't it? Is this needed to solve this bug or can this be handled separately?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that is required because for REST requests the kernel does not return a view.
Then, as it is not a view, it returns
nulland nothing is tagged accordingly.Please note that when we return null here, the response is cached for the default time.