[WIP] Base field type by kore · Pull Request #191 · ezsystems/ezplatform

kore · 2017-07-10T09:29:49Z

Prototype with base field type, can be cleaned up & moved to correct / own repo at later point if this can be used for anything.

ezrobot · 2017-07-10T09:33:38Z

Tool version : PHP CS Fixer 2.1.2 by Fabien Potencier and Dariusz Ruminski
Command executed php-cs-fixer --dry-run -v fix
This Pull Request does not respect PSR-2 Coding Standards, please, see the suggested diff below:

diff --git a/src/Kore/RatingFieldTypeBundle/DependencyInjection/KoreRatingFieldTypeExtension.php b/src/Kore/RatingFieldTypeBundle/DependencyInjection/KoreRatingFieldTypeExtension.php
index a6c7be9..d281063 100644
--- a/src/Kore/RatingFieldTypeBundle/DependencyInjection/KoreRatingFieldTypeExtension.php
+++ b/src/Kore/RatingFieldTypeBundle/DependencyInjection/KoreRatingFieldTypeExtension.php
@@ -30,7 +30,7 @@ class KoreRatingFieldTypeExtension extends Extension implements PrependExtension
         $configuration = new Configuration();
         $config = $this->processConfiguration($configuration, $configs);
 
-        $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
+        $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
         $loader->load('services.xml');
     }
 }
diff --git a/src/Kore/RatingFieldTypeBundle/Storage/FieldType/Type.php b/src/Kore/RatingFieldTypeBundle/Storage/FieldType/Type.php
index cd8be21..b74066a 100644
--- a/src/Kore/RatingFieldTypeBundle/Storage/FieldType/Type.php
+++ b/src/Kore/RatingFieldTypeBundle/Storage/FieldType/Type.php
@@ -3,7 +3,6 @@
 namespace Kore\RatingFieldTypeBundle\Storage\FieldType;
 
 use eZ\Publish\Core\FieldType\FieldType;
-use eZ\Publish\API\Repository\Values\ContentType\FieldDefinition;
 use eZ\Publish\SPI\FieldType\Value as SPIValue;
 use eZ\Publish\Core\FieldType\Value as CoreValue;
 use eZ\Publish\SPI\Persistence\Content\FieldValue;
@@ -51,7 +50,7 @@ class Type extends FieldType
      *
      * @param mixed $inputValue
      *
-     * @return mixed The potentially converted input value.
+     * @return mixed the potentially converted input value
      */
     protected function createValueFromInput($inputValue)
     {
@@ -84,7 +83,7 @@ class Type extends FieldType
      *  }
      * </code>
      *
-     * @throws \eZ\Publish\API\Repository\Exceptions\InvalidArgumentException If the value does not match the expected structure.
+     * @throws \eZ\Publish\API\Repository\Exceptions\InvalidArgumentException if the value does not match the expected structure
      *
      * @param \eZ\Publish\Core\FieldType\Value $value
      */
diff --git a/src/Kore/RatingFieldTypeBundle/Storage/Legacy/Converter.php b/src/Kore/RatingFieldTypeBundle/Storage/Legacy/Converter.php
index 33943d5..d502112 100644
--- a/src/Kore/RatingFieldTypeBundle/Storage/Legacy/Converter.php
+++ b/src/Kore/RatingFieldTypeBundle/Storage/Legacy/Converter.php
@@ -24,12 +24,10 @@ class Converter implements ConverterInterface
 
     public function toStorageFieldDefinition(FieldDefinition $fieldDef, StorageFieldDefinition $storageDef)
     {
-
     }
 
     public function toFieldDefinition(StorageFieldDefinition $storageDef, FieldDefinition $fieldDef)
     {
-
     }
 
     public function getIndexColumn()

ezrobot · 2017-07-10T09:38:37Z

Tool version : PHP CS Fixer 2.1.2 by Fabien Potencier and Dariusz Ruminski
Command executed php-cs-fixer --dry-run -v fix
This Pull Request does not respect PSR-2 Coding Standards, please, see the suggested diff below:

diff --git a/src/Kore/RatingFieldTypeBundle/DependencyInjection/KoreRatingFieldTypeExtension.php b/src/Kore/RatingFieldTypeBundle/DependencyInjection/KoreRatingFieldTypeExtension.php
index a6c7be9..d281063 100644
--- a/src/Kore/RatingFieldTypeBundle/DependencyInjection/KoreRatingFieldTypeExtension.php
+++ b/src/Kore/RatingFieldTypeBundle/DependencyInjection/KoreRatingFieldTypeExtension.php
@@ -30,7 +30,7 @@ class KoreRatingFieldTypeExtension extends Extension implements PrependExtension
         $configuration = new Configuration();
         $config = $this->processConfiguration($configuration, $configs);
 
-        $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
+        $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
         $loader->load('services.xml');
     }
 }
diff --git a/src/Kore/RatingFieldTypeBundle/Storage/FieldType/Type.php b/src/Kore/RatingFieldTypeBundle/Storage/FieldType/Type.php
index a539abf..f446296 100644
--- a/src/Kore/RatingFieldTypeBundle/Storage/FieldType/Type.php
+++ b/src/Kore/RatingFieldTypeBundle/Storage/FieldType/Type.php
@@ -3,7 +3,6 @@
 namespace Kore\RatingFieldTypeBundle\Storage\FieldType;
 
 use eZ\Publish\Core\FieldType\FieldType;
-use eZ\Publish\API\Repository\Values\ContentType\FieldDefinition;
 use eZ\Publish\SPI\FieldType\Value as SPIValue;
 use eZ\Publish\Core\FieldType\Value as CoreValue;
 use eZ\Publish\SPI\Persistence\Content\FieldValue;
@@ -51,7 +50,7 @@ class Type extends FieldType
      *
      * @param mixed $inputValue
      *
-     * @return mixed The potentially converted input value.
+     * @return mixed the potentially converted input value
      */
     protected function createValueFromInput($inputValue)
     {
@@ -87,7 +86,7 @@ class Type extends FieldType
      *  }
      * </code>
      *
-     * @throws \eZ\Publish\API\Repository\Exceptions\InvalidArgumentException If the value does not match the expected structure.
+     * @throws \eZ\Publish\API\Repository\Exceptions\InvalidArgumentException if the value does not match the expected structure
      *
      * @param \eZ\Publish\Core\FieldType\Value $value
      */
diff --git a/src/Kore/RatingFieldTypeBundle/Storage/Legacy/Converter.php b/src/Kore/RatingFieldTypeBundle/Storage/Legacy/Converter.php
index 33943d5..d502112 100644
--- a/src/Kore/RatingFieldTypeBundle/Storage/Legacy/Converter.php
+++ b/src/Kore/RatingFieldTypeBundle/Storage/Legacy/Converter.php
@@ -24,12 +24,10 @@ class Converter implements ConverterInterface
 
     public function toStorageFieldDefinition(FieldDefinition $fieldDef, StorageFieldDefinition $storageDef)
     {
-
     }
 
     public function toFieldDefinition(StorageFieldDefinition $storageDef, FieldDefinition $fieldDef)
     {
-
     }
 
     public function getIndexColumn()

ezrobot · 2017-07-12T07:28:40Z

Tool version : PHP CS Fixer 2.1.2 by Fabien Potencier and Dariusz Ruminski
Command executed php-cs-fixer --dry-run -v fix
This Pull Request does not respect PSR-2 Coding Standards, please, see the suggested diff below:

diff --git a/src/Kore/RatingFieldTypeBundle/DependencyInjection/KoreRatingFieldTypeExtension.php b/src/Kore/RatingFieldTypeBundle/DependencyInjection/KoreRatingFieldTypeExtension.php
index a6c7be9..d281063 100644
--- a/src/Kore/RatingFieldTypeBundle/DependencyInjection/KoreRatingFieldTypeExtension.php
+++ b/src/Kore/RatingFieldTypeBundle/DependencyInjection/KoreRatingFieldTypeExtension.php
@@ -30,7 +30,7 @@ class KoreRatingFieldTypeExtension extends Extension implements PrependExtension
         $configuration = new Configuration();
         $config = $this->processConfiguration($configuration, $configs);
 
-        $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
+        $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
         $loader->load('services.xml');
     }
 }
diff --git a/src/Kore/RatingFieldTypeBundle/Storage/FieldType/Type.php b/src/Kore/RatingFieldTypeBundle/Storage/FieldType/Type.php
index b710d82..ee55c83 100644
--- a/src/Kore/RatingFieldTypeBundle/Storage/FieldType/Type.php
+++ b/src/Kore/RatingFieldTypeBundle/Storage/FieldType/Type.php
@@ -3,7 +3,6 @@
 namespace Kore\RatingFieldTypeBundle\Storage\FieldType;
 
 use eZ\Publish\Core\FieldType\FieldType;
-use eZ\Publish\API\Repository\Values\ContentType\FieldDefinition;
 use eZ\Publish\SPI\FieldType\Value as SPIValue;
 use eZ\Publish\Core\FieldType\Value as CoreValue;
 use eZ\Publish\SPI\Persistence\Content\FieldValue;
@@ -52,7 +51,7 @@ class Type extends FieldType
      *
      * @param mixed $inputValue
      *
-     * @return mixed The potentially converted input value.
+     * @return mixed the potentially converted input value
      */
     protected function createValueFromInput($inputValue)
     {
@@ -92,7 +91,7 @@ class Type extends FieldType
      *  }
      * </code>
      *
-     * @throws \eZ\Publish\API\Repository\Exceptions\InvalidArgumentException If the value does not match the expected structure.
+     * @throws \eZ\Publish\API\Repository\Exceptions\InvalidArgumentException if the value does not match the expected structure
      *
      * @param \eZ\Publish\Core\FieldType\Value $value
      */
diff --git a/src/Kore/RatingFieldTypeBundle/Tests/TypeIntegrationTest.php b/src/Kore/RatingFieldTypeBundle/Tests/TypeIntegrationTest.php
index 3349cae..96f1194 100644
--- a/src/Kore/RatingFieldTypeBundle/Tests/TypeIntegrationTest.php
+++ b/src/Kore/RatingFieldTypeBundle/Tests/TypeIntegrationTest.php
@@ -6,7 +6,6 @@ use eZ\Publish\SPI\Tests\FieldType\BaseIntegrationTest;
 use eZ\Publish\Core\FieldType;
 use eZ\Publish\SPI\Persistence\Content;
 use eZ\Publish\SPI\Persistence\Content\Field;
-
 use Kore\RatingFieldTypeBundle\Storage\FieldType\Type;
 use Kore\RatingFieldTypeBundle\Storage\FieldType\Value;
 use Kore\RatingFieldTypeBundle\Storage\Legacy\Converter;
diff --git a/src/Kore/RatingFieldTypeBundle/Tests/TypeTest.php b/src/Kore/RatingFieldTypeBundle/Tests/TypeTest.php
index 1ad84bc..7dcc75d 100644
--- a/src/Kore/RatingFieldTypeBundle/Tests/TypeTest.php
+++ b/src/Kore/RatingFieldTypeBundle/Tests/TypeTest.php
@@ -3,7 +3,6 @@
 namespace Kore\RatingFieldTypeBundle\Tests;
 
 use eZ\Publish\Core\FieldType\Tests\FieldTypeTest;
-
 use Kore\RatingFieldTypeBundle\Storage\FieldType\Type;
 use Kore\RatingFieldTypeBundle\Storage\FieldType\Value;

kore added 6 commits July 7, 2017 13:44

Prototyped PHP part of a custom field type

60f4760

Fixed converter definition

f26ef30

Stubbed and registered templates

69de188

Changed field type identifier to work with twig template blocks

cb5228d

Removed unused files

2690fae

Added docs and removed unnecessary method overrides

98a7c9c

Added another note

ffc35af

kore added 2 commits July 11, 2017 10:48

Implemented test for field type using base test class

6e1e190

Implemented external storage

7e10d85

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Base field type#191

[WIP] Base field type#191
kore wants to merge 9 commits intoezsystems:masterfrom
Qafoo:base-field-type

kore commented Jul 10, 2017 •

edited by andrerom

Loading

Uh oh!

ezrobot commented Jul 10, 2017

Uh oh!

ezrobot commented Jul 10, 2017

Uh oh!

ezrobot commented Jul 12, 2017

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

kore commented Jul 10, 2017 • edited by andrerom Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ezrobot commented Jul 10, 2017

Uh oh!

ezrobot commented Jul 10, 2017

Uh oh!

ezrobot commented Jul 12, 2017

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

kore commented Jul 10, 2017 •

edited by andrerom

Loading