Add --no-verify to ghstack submission#281
Merged
ezyang merged 1 commit intoezyang:masterfrom Apr 16, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
--no-verifyghstackThen,
ghstackfails with an error likeAs part of
ghstack, I think we should never care about precommit hooks failing. If precommit hooks are failing then users should then fix them manually. It can also leave the ghstack submit in a somewhat poor spot (e.g. half of the ghstack PRs opened but not the rest).So, I added
--no-verifytosubmit.py's push.