Skip to content

QOL: read creds from gh auth & infer pr urls from ssh remotes - #308

Merged
ezyang merged 3 commits into
ezyang:masterfrom
v0i0:v0i0/qol
Dec 20, 2025
Merged

QOL: read creds from gh auth & infer pr urls from ssh remotes#308
ezyang merged 3 commits into
ezyang:masterfrom
v0i0:v0i0/qol

Conversation

@v0i0

@v0i0 v0i0 commented Dec 19, 2025

Copy link
Copy Markdown
Contributor
  • grab credentials from gh cli
  • infer pr urls from ssh remotes, too

v0i0 and others added 3 commits December 19, 2025 17:35
Comment thread src/ghstack/config.py

# Get the username using gh api
username_result = subprocess.run(
["gh", "api", "user", "-q", ".login", "--hostname", github_url],

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is annoying, it implies an extra network roundtrip at startup every time

@ezyang
ezyang enabled auto-merge (squash) December 20, 2025 04:49
@ezyang
ezyang merged commit 27c1bc2 into ezyang:master Dec 20, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants