Conversation
nandantumu
left a comment
There was a problem hiding this comment.
Looks pretty good, but have a few questions
luigiberducci
left a comment
There was a problem hiding this comment.
Looks good to me.
I would integrate the creation of EDT directly into the track loading.
We can keep this as an example anyway or get rid of it.
|
@hzheng40 I have added a test for a kind of corner case we discussed in the last meeting. The changes proposed should address it. Scenario: Current behavior: Expected behavior: |
luigiberducci
left a comment
There was a problem hiding this comment.
a couple of changes necessary
| @@ -0,0 +1,41 @@ | |||
| from f110_gym.envs.track import Track | |||
There was a problem hiding this comment.
| from f110_gym.envs.track import Track | |
| from f1tenth_gym.envs.track import Track |
| if no map directory matching the track name is found | ||
| """ | ||
| map_dir = pathlib.Path(__file__).parent.parent.parent.parent / "maps" | ||
| map_dir = pathlib.Path(__file__).parent.parent.parent.parent.parent / "maps" |
There was a problem hiding this comment.
why this? it does not point to the right "maps" directory in this way
| map_dir = pathlib.Path(__file__).parent.parent.parent.parent.parent / "maps" | |
| map_dir = pathlib.Path(__file__).parent.parent.parent.parent / "maps" |
Addresses #107
set_map()