Use stream API rather than file copy#14
Merged
Meakk merged 1 commit intof3d-app:masterfrom Feb 18, 2026
Merged
Conversation
Meakk
force-pushed
the
many-improvements
branch
from
e0fdd71 to
5222733
Compare
Meakk
changed the title
mwestphal
reviewed
Feb 18, 2026
| try (InputStream inputStream = MainView.this.getContext().getContentResolver().openInputStream(mActiveUri)) { | ||
| if (inputStream != null) { | ||
| byte[] fileBytes = new byte[inputStream.available()]; | ||
| inputStream.read(fileBytes); |
Member
There was a problem hiding this comment.
i suppose this copy is unavoidable.
Member
Author
There was a problem hiding this comment.
That's the best way I could find.
Member
There was a problem hiding this comment.
Hat some point I considered adding a vtkIStreamResourceStream, would that help ?
Member
Author
There was a problem hiding this comment.
Maybe? Hard to tell at the moment but we'll most likely need a f3d::scene::add(std::istream& stream) api
Member
There was a problem hiding this comment.
well of course, thats the easy part though.
Member
Author
There was a problem hiding this comment.
So yeah, I think that'd help here too
mwestphal
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use stream directly rather than copying temporary files to cache.