Skip to content

Add webifc to superbuild#304

Merged
Meakk merged 5 commits intof3d-app:mainfrom
noclone:webifc
Feb 1, 2026
Merged

Add webifc to superbuild#304
Meakk merged 5 commits intof3d-app:mainfrom
noclone:webifc

Conversation

@noclone
Copy link
Contributor

@noclone noclone commented Jan 30, 2026

No description provided.

Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python wheel superbuild CI cache number should be changed to trigger a rebuild

@noclone
Copy link
Contributor Author

noclone commented Jan 30, 2026

python wheel superbuild CI cache number should be changed to trigger a rebuild

can you point the line that needs to be changed please ?

@mwestphal
Copy link
Member

python wheel superbuild CI cache number should be changed to trigger a rebuild

can you point the line that needs to be changed please ?

https://github.com/f3d-app/f3d-superbuild/blob/main/.github/actions/wheels/action.yml#L44

Sorry, I was in a rush yesterday.

@noclone noclone requested a review from mwestphal January 31, 2026 08:27
@noclone
Copy link
Contributor Author

noclone commented Jan 31, 2026

python wheel superbuild CI cache number should be changed to trigger a rebuild

can you point the line that needs to be changed please ?

https://github.com/f3d-app/f3d-superbuild/blob/main/.github/actions/wheels/action.yml#L44

Sorry, I was in a rush yesterday.

no worries, updated

#include <string>
#include <cmath>
#include <algorithm>
-#include <format>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is webifc C++20 ? I dont think they advertise it, maybe we should ask if they want this patch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they have set(CMAKE_CXX_STANDARD 20) in their cmakelists so it seems they are

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

however, format is the only c++20 usage

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, ill ask them on their forum then

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no answer yet, ill let uyou know if they do.

@noclone noclone requested a review from mwestphal February 1, 2026 17:24
@mwestphal mwestphal requested a review from Meakk February 1, 2026 17:25
@Meakk Meakk merged commit 2a2bb24 into f3d-app:main Feb 1, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants