Conversation
Introduce a protected `_mapEventDatum` method on ComponentCore that defaults to identity and is invoked in `_bindEvents` before calling event handlers. Override this in StackedBar to merge the event record with the original datum (for compatibility with a changed event data structure introduced during performance optimizations).
This was referenced Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent performance improvement PR introduced a breaking change to the event data structure of Stacked Bar, which I overlooked. This PR fixes it by mapping the data back to the original structure while also keeping the new
datumproperty for maximum compatibility.Before
After
It also addresses #692 by fixing the
isEndingcalculation.Before
After