Skip to content

puppet device --facts command returns same facts for both active and standby f5 devices #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sasubillis wants to merge 4 commits into
base: master
Choose a base branch
from
Open

puppet device --facts command returns same facts for both active and standby f5 devices #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
577d123
passing fqdn from url config to fatcs.rb
Jan 17, 2020
0e23949
hostfqdn got from devices.rb is used to make decision to which item f…
Jan 17, 2020
4387931
making sure lowercase comparision of given hostname
Jan 22, 2020
a1056e8
making lowercase comparision
Jan 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/puppet/util/network_device/f5/device.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,12 @@ def initialize(url, options = {})
end
if @autoloader.load(*autoloader_params)
@transport = Puppet::Util::NetworkDevice::Transport::F5.new(url,options[:debug])
@fqdn = url.split("@").last.downcase
end
end

def facts
@facts ||= Puppet::Util::NetworkDevice::F5::Facts.new(@transport)
@facts ||= Puppet::Util::NetworkDevice::F5::Facts.new(@transport, @fqdn)

return @facts.retrieve
end
Expand Down
9 changes: 7 additions & 2 deletions lib/puppet/util/network_device/f5/facts.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ class Puppet::Util::NetworkDevice::F5::Facts

attr_reader :transport

def initialize(transport)
def initialize(transport, hostfqdn)
@transport = transport
@hostfqdn = hostfqdn
end

def retrieve
Expand All @@ -17,7 +18,11 @@ def parse_device_facts
}

if response = @transport.call('/mgmt/tm/cm/device') and items = response['items']
result = items.first
if (items.first['name'].downcase) == @hostfqdn
result = items.first
else
result = items.last
end
else
Puppet.warning("Did not receive device details. iControl REST requires Administrator level access.")
return facts
Expand Down