Skip to content

Remove dependency on deprecated puppetlabs-pe_gem #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexjfisher wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove dependency on deprecated puppetlabs-pe_gem #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ group :development, :unit_tests do
gem 'rspec-puppet', :require => false
gem 'puppetlabs_spec_helper', :require => false
gem 'puppet-lint', :require => false
gem 'metadata-json-lint', :require => false
Copy link

@bastelfreak bastelfreak Nov 2, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you add the gem? If this is a needed dependency for one of the existing gems, then this should be addressed in a separate commit.

Copy link
Contributor Author

@alexjfisher alexjfisher Nov 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s a common mistake to remove the ‘dependencies’ key from the metadata if there are no dependencies. But this would make the metadata invalid, (if there are no dependencies, you still need an empty array). This gem guards against this from happening in the future.

gem 'pry', :require => false
gem 'parallel_tests', '< 2.10.0', :require => false if Gem::Version.new(RUBY_VERSION.dup) < Gem::Version.new('2.0.0')
gem 'parallel_tests', :require => false if Gem::Version.new(RUBY_VERSION.dup) >= Gem::Version.new('2.0.0')
Expand Down
5 changes: 4 additions & 1 deletion manifests/init.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
class f5 {
class { 'f5::install': }
package { 'faraday':
ensure => present,
provider => 'puppet_gem',
}
}
14 changes: 0 additions & 14 deletions manifests/install.pp
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,5 @@
}
],
"dependencies": [
{"name":"puppetlabs-pe_gem","version_requirement":">= 0.1.0 <1.0.0"}
]
}
3 changes: 3 additions & 0 deletions spec/classes/coverage_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
require 'rspec-puppet'

at_exit { RSpec::Puppet::Coverage.report! }
12 changes: 12 additions & 0 deletions spec/classes/f5_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
require 'spec_helper'

describe 'f5' do
it { is_expected.to compile.with_all_deps }
it { is_expected.to contain_class('f5') }
it do
is_expected.to contain_package('faraday').with(
'ensure' => 'present',
'provider' => 'puppet_gem'
)
end
end