-
Notifications
You must be signed in to change notification settings - Fork 0
[accless] Support Multi Attestation-Service Deployments #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @csegarragonz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive support for deploying and interacting with multiple attestation services, significantly enhancing the system's flexibility and scalability. The changes span across the Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces significant changes to support multiple attestation services and refactors how certificate paths are handled, moving from single PEM files to directories of certificates. Key changes include updating Cargo.lock for dependency bumps, adding a size check in abe4.cpp for robustness, and modifying attestation-related C++ functions (attestation.cpp, attestation.h, mock_sgx.cpp, mock_snp.cpp, snp.cpp) to accept asUrl and certPath as parameters instead of relying on environment variables. The Rust build script (jwt/build.rs) and CMake configuration (jwt/cpp-bindings/CMakeLists.txt) were updated to embed multiple .pem certificates from a specified directory (ACCLESS_AS_CERT_DIR). The accli command-line tool was refactored to remove a global debug flag, add an id argument for attestation services, and replace single cert_path arguments with cert_dir arguments. The accli now uses an ApplicationBackend enum (Cvm, Docker) for running applications, simplifying the execution logic. Azure provisioning scripts were enhanced to dynamically create and provision multiple attestation service VMs, and Ansible playbooks were updated to handle dynamic inventory and per-VM variables. A new multi-as test application was added to validate multi-attestation service functionality. The escrow-xput function was updated to support multiple attestation service URLs and certificate paths, and its CP-ABE policy logic was adjusted for load-balancing across multiple services. Plotting scripts were also updated to include a new AcclessSingleAuth baseline and temporarily skip plotting AcclessMaa. Review comments highlighted the need for more descriptive error messages when unwrap() is used in build.rs and suggested extracting duplicated VM name generation logic in accli/src/main.rs into a helper function for better maintainability.
7468857 to
8d99109
Compare
8d99109 to
ce00b0a
Compare
ce00b0a to
12aa63a
Compare
254c421 to
9f9de07
Compare
9f9de07 to
6267e46
Compare
Closes #49