[RN 0.82] Vendor JSONArguments to JSONToWritableMap #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
changed the title
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jul 29, 2025
Summary: I'm removing this class as we should not expose it publicly. It's not used at all inside react-native and can potentally be moved internally. The only usage I've found in OSS is patched with this PR: - fabOnReact/react-native-wear-connectivity#46 Changelog: [Android] [Removed] - Remove the `com.facebook.react.bridge.JSONArguments` class Reviewed By: javache, mdvacca Differential Revision: D78265165
fabOnReact
added a commit
that referenced
this pull request
Jul 29, 2025
This reverts commit 41de25c.
This was referenced Jul 29, 2025
|
Thanks a lot. I'll wait for 0.82 and then publish a new release. I reverted and republished the PR as #49 to be merged in main later. |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jul 29, 2025
…52901) Summary: Pull Request resolved: facebook#52901 I'm removing this class as we should not expose it publicly. It's not used at all inside react-native and can potentally be moved internally. The only usage I've found in OSS is patched with this PR: - fabOnReact/react-native-wear-connectivity#46 Changelog: [Android] [Removed] - Remove the `com.facebook.react.bridge.JSONArguments` class Reviewed By: javache, mdvacca Differential Revision: D78265165
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jul 29, 2025
…52901) Summary: Pull Request resolved: facebook#52901 I'm removing this class as we should not expose it publicly. It's not used at all inside react-native and can potentally be moved internally. The only usage I've found in OSS is patched with this PR: - fabOnReact/react-native-wear-connectivity#46 Changelog: [Android] [Removed] - Remove the `com.facebook.react.bridge.JSONArguments` class Reviewed By: javache, mdvacca Differential Revision: D78265165
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Jul 29, 2025
Summary: Pull Request resolved: #52901 I'm removing this class as we should not expose it publicly. It's not used at all inside react-native and can potentally be moved internally. The only usage I've found in OSS is patched with this PR: - fabOnReact/react-native-wear-connectivity#46 Changelog: [Android] [Removed] - Remove the `com.facebook.react.bridge.JSONArguments` class Reviewed By: javache, mdvacca Differential Revision: D78265165 fbshipit-source-id: 704575e7b9cfd6d40980511d6064d39991b3eb48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking into making the class
com.facebook.react.bridge.JSONArgumentsinternal.This is the only usage I've found of such class in OSS.
Here I'm copying over the code that you're using for the method
fromJSONObjectonly.