-
Notifications
You must be signed in to change notification settings - Fork 9
feat: add Garmin connector #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fabOnReact
wants to merge
1
commit into
main
Choose a base branch
from
codex/integrate-react-native-garmin-connect
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
import { NativeEventEmitter } from 'react-native'; | ||
import GarminConnect from 'react-native-garmin-connect'; | ||
|
||
/** | ||
* Provides a small wrapper around the Garmin Connect SDK. | ||
* The connector exposes a simple API used by the library to | ||
* communicate with Garmin wearables. | ||
*/ | ||
class GarminConnector { | ||
private emitter: NativeEventEmitter; | ||
|
||
constructor() { | ||
// GarminConnect is a native module; wrap it with an event emitter so we | ||
// can subscribe to SDK events from JavaScript. | ||
this.emitter = new NativeEventEmitter(GarminConnect as any); | ||
} | ||
|
||
/** | ||
* Initializes the Garmin SDK. | ||
*/ | ||
initialize(): Promise<void> { | ||
// The SDK exposes an initialize call which prepares the connection layer. | ||
return GarminConnect.initialize(); | ||
} | ||
|
||
/** | ||
* Sends a payload to a paired Garmin device. | ||
*/ | ||
sendMessage(message: Record<string, unknown>): Promise<void> { | ||
return GarminConnect.sendMessage(message); | ||
} | ||
|
||
/** | ||
* Adds a listener for incoming messages from the Garmin device. | ||
* Returns an unsubscribe function to remove the listener. | ||
*/ | ||
onMessage(callback: (message: any) => void): () => void { | ||
const subscription = this.emitter.addListener('message', callback); | ||
return () => subscription.remove(); | ||
} | ||
} | ||
|
||
export default new GarminConnector(); | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Guard Garmin connector when native module is unavailable
The new wrapper calls
GarminConnect.initialize()
andGarminConnect.sendMessage()
directly. On iOS (and on Android projects that haven’t copied Garmin’s native SDK yet),react-native-garmin-connect
resolves toundefined
, so invoking either method will throw a runtime exception as soon as the connector is used. Other APIs in this package (sendMessage
,watchEvents
) already gate native calls behind platform checks to avoid crashing on unsupported platforms. The Garmin connector should similarly no-op or warn when the native module is missing so that importing the package in cross‑platform code doesn’t crash apps that aren’t set up for Garmin yet.Useful? React with 👍 / 👎.