-
Notifications
You must be signed in to change notification settings - Fork 9
feat: add WearOS connector #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fabOnReact
wants to merge
1
commit into
main
Choose a base branch
from
codex/add-react-native-wear-connectivity-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| import type { Payload, ReplyCallback, ErrorCallback } from '../NativeWearConnectivity'; | ||
| import { sendMessage } from '../messages'; | ||
| import { watchEvents } from '../subscriptions'; | ||
|
|
||
| /** | ||
| * Simple helper class that forwards messages between the React Native app and the Wear OS app. | ||
| * | ||
| * It wraps the existing `sendMessage` API and exposes a convenient method to | ||
| * subscribe to incoming messages coming from the Wear OS companion application. | ||
| */ | ||
| class WearOSConnector { | ||
| private unsubscribe?: () => void; | ||
|
|
||
| /** | ||
| * Register a listener for messages coming from the Wear OS app. | ||
| * | ||
| * @param listener Callback invoked every time a message is received. | ||
| * @returns Function to remove the registered listener. | ||
| */ | ||
| connect(listener: (message: Payload) => void) { | ||
| this.unsubscribe = watchEvents.on('message', listener); | ||
| return this.unsubscribe; | ||
| } | ||
|
|
||
| /** | ||
| * Remove the current message listener, if any. | ||
| */ | ||
| disconnect() { | ||
| if (this.unsubscribe) { | ||
| this.unsubscribe(); | ||
| this.unsubscribe = undefined; | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Send a message to the Wear OS app. | ||
| * | ||
| * @param message Message payload to send. | ||
| * @param cb Optional callback invoked on success. | ||
| * @param errCb Optional callback invoked on error. | ||
| */ | ||
| send(message: Payload, cb?: ReplyCallback, errCb?: ErrorCallback) { | ||
| sendMessage(message, cb, errCb); | ||
| } | ||
| } | ||
|
|
||
| const connector = new WearOSConnector(); | ||
| export default connector; | ||
| export type { Payload }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Pass required callbacks when delegating to sendMessage
The new helper declares
cbanderrCbas optional, but forwards them directly tosendMessage.sendMessage’s signature requires both callbacks, so under the repo’sstrictTypeScript configuration this call producesTS2345: Argument of type 'ReplyCallback | undefined' is not assignable to parameter of type 'ReplyCallback'and the package no longer type-checks. Provide defaults or narrow the values before callingsendMessageso the build can succeed.Useful? React with 👍 / 👎.