Skip to content

Commit 5cfb886

Browse files
kelsetfacebook-github-bot
authored andcommitted
fix (deps): add explicitly eslint config to dependencies (facebook#35192)
Summary: Basically since this change facebook#34423 everything worked ok because in the main branch where the monorepo has the workspace section and everything, `react-native-community/eslint-config` was getting pulled in as a node_module anyway - but when moving to a stable branch and wanting to do a release, as we are now with 0.71, because of what the final package.json looks like for react-native and [the modifications that it goes through](facebook@f0054e1#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519) (ex. the `workspace` section disappears), the fact that it's not directly listed as dependency makes [the CI fails](https://app.circleci.com/pipelines/github/facebook/react-native/17124/workflows/54a4162d-f466-4eab-94ba-ec9fe77e2ecf/jobs/339643) with `Error: Failed to load config "react-native-community" to extend from.` ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [General] [Fixed] - add explicitly eslint config to dependencies Pull Request resolved: facebook#35192 Test Plan: In 0.71, add the deps to see the error disappear (it gets replaced by a different one though, looking into that) Reviewed By: jacdebug, cortinico Differential Revision: D40988407 Pulled By: cipolleschi fbshipit-source-id: 38f433a0b4b47a7cb61b59e887459d11182a5b4b
1 parent ad43dec commit 5cfb886

File tree

2 files changed

+24
-0
lines changed

2 files changed

+24
-0
lines changed
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
load("@fbsource//tools/build_defs/third_party:yarn_defs.bzl", "yarn_workspace")
2+
3+
yarn_workspace(
4+
name = "yarn-workspace",
5+
srcs = glob(
6+
["**/*.js"],
7+
exclude = [
8+
"**/__fixtures__/**",
9+
"**/__flowtests__/**",
10+
"**/__mocks__/**",
11+
"**/__server_snapshot_tests__/**",
12+
"**/__tests__/**",
13+
"**/node_modules/**",
14+
"**/node_modules/.bin/**",
15+
"**/.*",
16+
"**/.*/**",
17+
"**/.*/.*",
18+
"**/*.xcodeproj/**",
19+
"**/*.xcworkspace/**",
20+
],
21+
),
22+
visibility = ["PUBLIC"],
23+
)

repo-config/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
"@babel/generator": "^7.14.0",
1515
"@babel/plugin-transform-regenerator": "^7.0.0",
1616
"@definitelytyped/dtslint": "^0.0.127",
17+
"@react-native-community/eslint-config": "*",
1718
"@react-native-community/eslint-plugin": "*",
1819
"@react-native/eslint-plugin-specs": "^0.71.1",
1920
"@reactions/component": "^2.0.2",

0 commit comments

Comments
 (0)