[ESM Compliance] Add import file extensions#165
Open
sachaw wants to merge 1 commit intofabian-hiller:mainfrom
Open
[ESM Compliance] Add import file extensions#165sachaw wants to merge 1 commit intofabian-hiller:mainfrom
sachaw wants to merge 1 commit intofabian-hiller:mainfrom
Conversation
❌ Deploy Preview for modularforms failed.
|
Owner
|
Thanks for creating this PR. I plan to rewrite Modular Forms in January. I will add the file extensions then. Would it help you to merge this PR before? |
Author
|
I'm happy to wait out, glad to hear you have greater plans for this library. |
fabian-hiller
force-pushed
the
main
branch
6 times, most recently
from
d40777c to
750b759
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, would you be open to a bringing this package in-compliance with the ESM spec, all that's required to to add import and export file extensions. This currently blocks usage of the modern node module resolution algorithm for projects that wish to use it.
I can include commits for the other packages if you are happy with the changes.
Thanks.