fix: Enhance JSDoc numeric format support and validation#357
Open
clicktodev wants to merge 6 commits intofabien0102:mainfrom
Open
fix: Enhance JSDoc numeric format support and validation#357clicktodev wants to merge 6 commits intofabien0102:mainfrom
clicktodev wants to merge 6 commits intofabien0102:mainfrom
Conversation
…ptional and nullable support
Author
|
@fabien0102 would be nice if you merged this! |
…Zod schema generation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce support for additional numeric formats in JSDoc tags and implement custom validation for these formats in the
buildZodPrimitiveInternalfunction.Tests added.
this fixes the case for int64 and uint64 numbers and also fixes the validation for strings that represent numbers
closes #355
this also covers #356
this fixes
Property 'int64' does not exist on type 'ZodString'by adding validation logic for ints.it can also be fixed by skipping int validation entirely for strings.
i think this behavior should be configurable? validating strings as valid numbers should be optional or not?