Skip to content

Fix deprecated Poetry config and clarify installation docs for #16#36

Closed
Copilot wants to merge 2 commits intomainfrom
copilot/fix-keyerror-transfer-parameters
Closed

Fix deprecated Poetry config and clarify installation docs for #16#36
Copilot wants to merge 2 commits intomainfrom
copilot/fix-keyerror-transfer-parameters

Conversation

Copy link

Copilot AI commented Nov 26, 2025

The KeyError: 'transfer_parameters' issue is already resolved via the FailSpy/steam-py-lib fork dependency. PyPI publishing remains blocked because PyPI doesn't support git dependencies.

Changes

  • pyproject.toml: Replace deprecated [tool.poetry.dev-dependencies] with [tool.poetry.group.dev.dependencies]
  • README.md: Update installation docs to clearly mark Poetry as the recommended method and add warning about PyPI unavailability
# Before
[tool.poetry.dev-dependencies]

# After  
[tool.poetry.group.dev.dependencies]

Notes

Manual installation via Poetry works correctly. PyPI publishing requires either the fork to be published under a new package name or the upstream steam library to merge the fix.

Original prompt

This section details on the original issue you should resolve

<issue_title>KeyError: 'transfer_parameters'</issue_title>
<issue_description>Hi, when I try to execute command steam-market-history export --json get the following error
KeyError: 'transfer_parameters' in webauth.py", line 209, in login self._finalize_login(resp)

I'm not using the Linux system, I'm using this project on Windows10 and using Pycharm to run it

using Python 3.12.0
steam-market-history Version: 3.1.0</issue_description>

Comments on the Issue (you are @copilot in this section)

@fabieu It seems Valve changed their login mechanism (as stated here https://github.com/ValvePython/steam/issues/450). The official library is not active anymore, so I will need to change the entire Steam authentication process and adapt a new library. This will take a few weeks, since I currently have not much time for this. @fabieu We are currently waiting for https://github.com/ValvePython/steam/pull/459 to be approved by a Valve developer. As mentioned before, the repository looks pretty abandoned. Due to security concerns, I am not willing to use a fork of the original repository. @fabieu > It is worth noting that that repo is not associated in any way with Valve or Valve developers, as far as I'm aware. It is an unofficial library. > > ![image](https://private-user-images.githubusercontent.com/9100196/340052862-39f30625-cbfb-4a6e-a1eb-28baa5f236c0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTg1MzE1MjYsIm5iZiI6MTcxODUzMTIyNiwicGF0aCI6Ii85MTAwMTk2LzM0MDA1Mjg2Mi0zOWYzMDYyNS1jYmZiLTRhNmUtYTFlYi0yOGJhYTVmMjM2YzAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYxNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MTZUMDk0NzA2WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZWQ3OWI4ODIxNDdlMWNmMjU1YjFkMGRhODQyMWQ2NzBhYTU0OWRjMjNmZTAxZWQ5MzgwZjdhZDIyYjM4MTU3YiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.EVMxb8ZDIZUycb9FYDFHaq-OlOFhsFPz4IWbOBkt8-s) > > My suggestion, if you change your mind and would like to give the fork a chance, is to review the few commits I've published to that repo, and pin your pyproject.toml dependencies list to a specific commit hash. That way even if the fork were later updated to have harmful behavior, your users would be unaffected as they would only be using the exact version you inspected. > > An example of pinning a git hash can be found here: https://python-poetry.org/docs/dependency-specification/#git-dependencies

You are totally right, didnt' notice this at first. I appreciate your commitment. I don't like the general idead of referencing git depencies due to their boundary to source code. I would like to establish your fork as the new maintained version of the steam authentication library. I would contribute the CI process of builing PyPi packages and update the documentation.</comment_new>
<comment_new>@fabieu
@FailSpy Unfortunatly it is not possible to upload a python package to PyPI with a git dependency as you recommended. Would it be possible to publish your version of the steam-py-lib to a package registry like PyPI. I could create a Pull Request for GitHub Actions.</comment_new>
<comment_new>@
Just verifying: there is no workaround for the 'transfer_parameters' issue, correct? Thanks!</comment_new>
<comment_new>@fabieu

Just verifying: there is no workaround for the 'transfer_parameters' issue, correct? Thanks!

Unfortunatly not really. You could run the steam-market-history-exporter by installing it manually (see reference)
But support for publishing the package to PyPi (pip) is currently on hold.</comment_new>


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: fabieu <43068791+fabieu@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix KeyError in Steam market history export Fix deprecated Poetry config and clarify installation docs for #16 Nov 26, 2025
Copilot AI requested a review from fabieu November 26, 2025 22:04
@fabieu fabieu closed this Nov 29, 2025
@fabieu fabieu deleted the copilot/fix-keyerror-transfer-parameters branch November 29, 2025 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KeyError: 'transfer_parameters'

2 participants