Add support for "surrogate pairs" in unmatched characters#3
Open
webpro wants to merge 1 commit intofabiospampinato:masterfrom
Open
Add support for "surrogate pairs" in unmatched characters#3webpro wants to merge 1 commit intofabiospampinato:masterfrom
webpro wants to merge 1 commit intofabiospampinato:masterfrom
Conversation
Owner
|
Is this essentially about "invalid" surrogate pairs? 🤔 could you update the PR to work on the current version of the library? I suppose we should support this, hopefully without slowing things down. |
# Conflicts: # src/index.ts # test/index.js
a6de877 to
d20dd64
Compare
Author
✅
✅
If anything, it should speed up things as it does less work. Running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for a great package, been very useful.
Hit an odd bug:
The
indexshould be 2. While this looks fine:Also, not sure if you even want to support this, feel free to reject. But I've tried to fix up the unmatched part anyway. Also not sure if it's up to your vision/standards, but happy to adjust.