feat: Simplify Sonarr, Radarr, Lidarr, and Prowlarr Config Management#58
Draft
google-labs-jules[bot] wants to merge 5 commits intomasterfrom
Draft
feat: Simplify Sonarr, Radarr, Lidarr, and Prowlarr Config Management#58google-labs-jules[bot] wants to merge 5 commits intomasterfrom
google-labs-jules[bot] wants to merge 5 commits intomasterfrom
Conversation
This change simplifies the configuration management for Sonarr, Radarr, Lidarr, and Prowlarr by centralizing the API key in a ConfigMap and using environment variables for the base URL. The following changes were made: - A single API key is now shared across all applications and is stored in a `ConfigMap`. - The API key is injected as an environment variable into each deployment. - The base URL for each application is now set via an environment variable. - The init containers that previously wrote the base URL to the `config.xml` file have been removed. - The liveness and readiness probes have been updated to use the API key from the environment variable. - Readarr has also been refactored to use the same configuration pattern.
Contributor
Author
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
fabito
reviewed
Dec 26, 2025
This change simplifies the configuration management for Sonarr, Radarr, Lidarr, and Prowlarr by centralizing the API key in a ConfigMap and using environment variables for the base URL. The following changes were made: - A single API key is now shared across all applications and is stored in a `ConfigMap`. - The API key is injected as an environment variable into each deployment. - The base URL for each application is now set via an environment variable. - The init containers that previously wrote the base URL to the `config.xml` file have been removed. - The liveness and readiness probes have been updated to use the API key from the environment variable. - Readarr has also been refactored to use the same configuration pattern. - The `LIDARR__AUTH__METHOD` and `LIDARR__AUTH__REQUIRED` environment variables have been restored as requested.
fabito
reviewed
Dec 26, 2025
This change simplifies the configuration management for Sonarr, Radarr, Lidarr, and Prowlarr by centralizing the API key in a ConfigMap and using environment variables for the base URL. The following changes were made: - A single API key is now shared across all applications and is stored in a `ConfigMap`. - The API key is injected as an environment variable into each deployment. - The base URL for each application is now set via an environment variable. - The init containers that previously wrote the base URL to the `config.xml` file have been removed. - The liveness and readiness probes have been updated to use the API key from the environment variable. - Readarr has also been refactored to use the same configuration pattern. - The `LIDARR__AUTH__METHOD` and `LIDARR__AUTH__REQUIRED` environment variables have been restored as requested. - The syntax for the environment variables in the probes has been corrected.
fabito
reviewed
Dec 26, 2025
This change simplifies the configuration management for Sonarr, Radarr, Lidarr, and Prowlarr by centralizing the API key in a ConfigMap and using environment variables for the base URL. The following changes were made: - A single API key is now shared across all applications and is stored in a `ConfigMap` generated by kustomize. - The API key is injected as an environment variable into each deployment. - The base URL for each application is now set via an environment variable. - The init containers that previously wrote the base URL to the `config.xml` file have been removed. - The liveness and readiness probes have been updated to use the API key from the environment variable. - Readarr has also been refactored to use the same configuration pattern. - The `LIDARR__AUTH__METHOD` and `LIDARR__AUTH__REQUIRED` environment variables have been restored as requested. - The syntax for the environment variables in the probes has been corrected. - The `ConfigMap` is now generated using a `configMapGenerator` in the `kustomization.yaml` file.
fabito
reviewed
Dec 26, 2025
Comment on lines
230
to
254
Owner
There was a problem hiding this comment.
The bazarr config init container needs to be fixed and simplified
- No need to parse api keys from radarr and sonarr config file - just use the api key from the shared config map
-
ipandbase_urlare broken after the removal of the vars:$(SONARR) and $ (RADARR)
Contributor
Author
There was a problem hiding this comment.
I have updated the bazarr deployment to use the shared API key and the correct service names for Sonarr and Radarr.
This change simplifies the configuration management for Sonarr, Radarr, Lidarr, and Prowlarr by centralizing the API key in a ConfigMap and using environment variables for the base URL. The following changes were made: - A single API key is now shared across all applications and is stored in a `ConfigMap` generated by kustomize. - The API key is injected as an environment variable into each deployment. - The base URL for each application is now set via an environment variable. - The init containers that previously wrote the base URL to the `config.xml` file have been removed. - The liveness and readiness probes have been updated to use the API key from the environment variable. - Readarr has also been refactored to use the same configuration pattern. - The `LIDARR__AUTH__METHOD` and `LIDARR__AUTH__REQUIRED` environment variables have been restored as requested. - The syntax for the environment variables in the probes has been corrected. - The `ConfigMap` is now generated using a `configMapGenerator` in the `kustomization.yaml` file. - The `bazarr` deployment has been updated to use the shared API key and the correct service names for Sonarr and Radarr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change simplifies the configuration management for Sonarr, Radarr, Lidarr, and Prowlarr by centralizing the API key in a ConfigMap and using environment variables for the base URL. This removes the need for init containers that write to the config.xml file.
PR created automatically by Jules for task 10455851715673433275 started by @fabito