Conversation
reese
force-pushed
the
reese-empty-string-alloc
branch
from
b515c3a to
79df6b3
Compare
froydnj
approved these changes
Dec 30, 2025
reese
force-pushed
the
reese-empty-string-alloc
branch
from
79df6b3 to
7dfe589
Compare
froydnj
reviewed
Dec 30, 2025
| pub fn is_single_line_breakable_garbage(&self) -> bool { | ||
| match self { | ||
| Self::DirectPart { part } => part == &"".to_string(), | ||
| Self::DirectPart { part } => part.is_empty(), |
Collaborator
There was a problem hiding this comment.
I have to say, this is not my favorite clippy lint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
taps the sign