Skip to content

[prism] Avoid allocating Strings by threading 'src lifetime throughout parser state and node types #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reese merged 4 commits into from
Jan 1, 2026
Merged

[prism] Avoid allocating Strings by threading 'src lifetime throughout parser state and node types #745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f72491f
Thread lifetimes through ParserState and associated structs
reese Jan 1, 2026
e790dd3
[prism] Add lifetimes to formatting functions
reese Jan 1, 2026
d07e1c4
Remove a bunch of _to_string calls and clones
reese Jan 1, 2026
6943bba
fmt
reese Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion librubyfmt/src/comment_block.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ impl CommentBlock {
self.comments.push(line);
}

pub fn into_line_tokens(self) -> impl Iterator<Item = ConcreteLineToken> {
pub fn into_line_tokens<'src>(self) -> impl Iterator<Item = ConcreteLineToken<'src>> {
self.comments.into_iter().flat_map(|c| {
[
ConcreteLineToken::Comment { contents: c },
Expand Down
8 changes: 4 additions & 4 deletions librubyfmt/src/delimiters.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,25 +82,25 @@ impl BreakableDelims {
}
}

pub fn single_line_open(&self) -> ConcreteLineToken {
pub fn single_line_open<'src>(&self) -> ConcreteLineToken<'src> {
ConcreteLineToken::Delim {
contents: self.single_line.open,
}
}

pub fn single_line_close(&self) -> ConcreteLineToken {
pub fn single_line_close<'src>(&self) -> ConcreteLineToken<'src> {
ConcreteLineToken::Delim {
contents: self.single_line.close,
}
}

pub fn multi_line_open(&self) -> ConcreteLineToken {
pub fn multi_line_open<'src>(&self) -> ConcreteLineToken<'src> {
ConcreteLineToken::Delim {
contents: self.multi_line.open,
}
}

pub fn multi_line_close(&self) -> ConcreteLineToken {
pub fn multi_line_close<'src>(&self) -> ConcreteLineToken<'src> {
ConcreteLineToken::Delim {
contents: self.multi_line.close,
}
Expand Down
Loading