Skip to content

Don't allocate a Vec for non_null_positions #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reese merged 1 commit into from
Jan 1, 2026
Merged

Don't allocate a Vec for non_null_positions #746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions librubyfmt/src/format_prism.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4738,8 +4738,8 @@ fn handle_string_at_offset<'src>(
ps.emit_ident(ident);
}

fn non_null_positions<'src>(params: &prism::ParametersNode<'src>) -> Vec<bool> {
vec![
fn non_null_positions<'src>(params: &prism::ParametersNode<'src>) -> [bool; 7] {
[
!params.requireds().is_empty(),
!params.optionals().is_empty(),
params.rest().is_some(),
Expand Down
4 changes: 2 additions & 2 deletions librubyfmt/src/ripper_tree_types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1264,8 +1264,8 @@ def_tag!(args_forward_tag, "args_forward");
pub struct ArgsForward(pub args_forward_tag, pub StartEnd);

impl Params {
pub fn non_null_positions(&self) -> Vec<bool> {
vec![
pub fn non_null_positions(&self) -> [bool; 7] {
[
(self.1).is_some(),
(self.2).is_some(),
(self.3).is_some(),
Expand Down