[DNM] Delete Ripper implementation #784
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reese
force-pushed
the
reese-ruby-embed-removal
branch
2 times, most recently
from
e6a62d6 to
4898510
Compare
reese
force-pushed
the
reese-ruby-embed-removal
branch
from
4898510 to
59631b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE - this is just a bit of show-and-tell so it's ready for whenever we're fully confident in the Prism implementation.
As of now, it seems like the difference between the Ripper and Prism implementations is pretty small, and many of the diffs that are generated are mostly fixes for bugs that exist only in Ripper (or are sufficiently rare and don't affect the runtime behavior that I think we can live with them). Given how small the diff is, I don't think it's worth having a version with the
--prismflag, and instead we should just shift over to Prism being the main implementation for the next release we cut.I don't intend to land this until Stripe folks give it a green light -- there may still be some lingering changes we need to make before we fully land this -- but I had it around as part of building https://rubyfmt.run (check it out!) so I figured I'd go ahead and have it up and ready.
The vast majority of the deletions are of course the Ripper tree types, deserialization code, and the Ruby VM checkout. There's also some deletions of token types, error types, and parser state methods that were only used by the Ripper implementation and were flagged by the compiler as dead code. There's more cleanup that we could do after this, but I wanted to keep this at a reasonable size, so I figure there would be follow-ons later.