Skip to content

Speed up comment presence checks #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reese merged 1 commit into from
Jan 18, 2026
Merged

Speed up comment presence checks #799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions librubyfmt/src/file_comments.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use std::collections::{BTreeSet, HashSet};
use std::collections::BTreeSet;

use crate::comment_block::CommentBlock;
use crate::parser_state::line_difference_requires_newline;
Expand Down Expand Up @@ -66,7 +66,8 @@ pub struct FileComments {
lines_with_ruby: BTreeSet<LineNumber>,
last_lineno: LineNumber,
line_index: LineIndex,
comment_start_offsets: HashSet<usize>,
/// Sorted list of byte offsets where comments start
comment_start_offsets: Vec<usize>,
}

impl FileComments {
Expand All @@ -80,7 +81,7 @@ impl FileComments {
);
file_comments
.comment_start_offsets
.insert(comment.location().start_offset());
.push(comment.location().start_offset());
}

// Lookup lines that have any Ruby
Expand Down Expand Up @@ -180,11 +181,13 @@ impl FileComments {
start_offset: SourceOffset,
end_offset: SourceOffset,
) -> bool {
let range = start_offset..end_offset;
let idx = self
.comment_start_offsets
.partition_point(|&offset| offset < start_offset);

self.comment_start_offsets
.iter()
.any(|offset| range.contains(offset))
.get(idx)
.is_some_and(|&offset| offset < end_offset)
}

pub fn extract_comments_to_line(
Expand Down