Conversation
froydnj
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #832
Currently, we build everything into
str/Stringtypes, which assume that the string contents are valid UTF-8. This will not always be the case -- Prism can output strings of any Ruby-supported encoding, so this assumption is unsafe and causes failures. Instead, we should be operating on sequences ofu8. This PR is the first step in that direction, makinginto_rubyreturn aCow<'_, [u8]>instead of aCow<'_, str>, as well as updatesemit_opto take&[u8]as a proof-of-concept. Later PRs will move other callers to useu8s, though I didn't want to have a single big-bang PR, so this is cut down to something reasonable for reviewability.The bulk of this PR is updating callsites, primarily converting str literals from
""tob""or for locs changing fromloc_to_str(loc)toloc.as_slice().