Conversation
reese
commented
Feb 28, 2026
| regex = "1.11.1" | ||
| rubyfmt = { path = "./librubyfmt" } | ||
| similar = "2.1.0" | ||
| similar = { version = "2.7.0", features = ["bytes"] } |
Collaborator
Author
There was a problem hiding this comment.
The update to 2.7.0 is just to keep us current with the latest version -- it doesn't have any functional differences as far as I can tell, just a bit of 🧹
The bytes feature is so that we can pass u8 Vecs to TextDiff::from_lines, which by default only handles strings.
froydnj
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
format_buffercurrently returns aStringand assumes that we always return valid UTF-8. With the changes I'm making for #832, this will no longer be the case, since Ruby source is not always UTF-8 encoded.