-
Notifications
You must be signed in to change notification settings - Fork 0
Adds node nickname functionality #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds node nickname functionality #11
Conversation
…ing-in-node-ui Fix nickname overlapping
|
An important note is to improve the alignment between the caption and the nickname when the last is created. |
|
It is important to note that an example of the nickname behavior (which would be used after in the paceholder's pr) was not made, as the whole structure of the nickname is made in outside layers of code, and the current example nodes (calculator) are good examples already. |
tatatupi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is examples missing. Perhaps implement it in the Calculator example, at the very least.
|
|
||
| virtual QRect resizeHandleRect(NodeId const nodeId) const = 0; | ||
|
|
||
| virtual int getPortSpasing() = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lacks documentation. Especially being a pure virtual method. And I guess there is a typo
Did you mean spacing?
EDIT: _spacing was already being used and had been implemented by other developers. However, I am still unclear about the usage of this method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, tests are not passing anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The funtionality and UI looks perfectly fine! Just check and resolve the conflicts in the exemple and other classes.
|
Now the example of the nickname functionality is in the Style example. |
This PR adds the nickname feature that was present in nodeeditor V1. Now, it is updated to seamlessly adapt to nodeeditor V3. A nickname changing feature via node UI is also included in the changes.