Skip to content

Conversation

@g-abilio
Copy link

This PR adds the nickname feature that was present in nodeeditor V1. Now, it is updated to seamlessly adapt to nodeeditor V3. A nickname changing feature via node UI is also included in the changes.

@g-abilio g-abilio requested a review from tatatupi July 25, 2025 23:06
@g-abilio
Copy link
Author

An important note is to improve the alignment between the caption and the nickname when the last is created.

@g-abilio
Copy link
Author

g-abilio commented Aug 4, 2025

It is important to note that an example of the nickname behavior (which would be used after in the paceholder's pr) was not made, as the whole structure of the nickname is made in outside layers of code, and the current example nodes (calculator) are good examples already.

Copy link

@tatatupi tatatupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is examples missing. Perhaps implement it in the Calculator example, at the very least.


virtual QRect resizeHandleRect(NodeId const nodeId) const = 0;

virtual int getPortSpasing() = 0;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lacks documentation. Especially being a pure virtual method. And I guess there is a typo
Did you mean spacing?

EDIT: _spacing was already being used and had been implemented by other developers. However, I am still unclear about the usage of this method.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, tests are not passing anymore

@g-abilio g-abilio requested a review from tatatupi September 18, 2025 14:38
@Gabrielnmds Gabrielnmds self-requested a review December 9, 2025 18:24
Copy link

@Gabrielnmds Gabrielnmds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The funtionality and UI looks perfectly fine! Just check and resolve the conflicts in the exemple and other classes.

@g-abilio g-abilio requested a review from Gabrielnmds December 10, 2025 18:19
@g-abilio
Copy link
Author

Now the example of the nickname functionality is in the Style example.

@g-abilio g-abilio merged commit cc81264 into master Dec 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants